Dead Hackers Society
Other BBSes »
 
 
Demoscene   Coding   CT60   Buy/sell

Atari demoscene BBS
 
Re: Performance problems
Posted by: nerve May,01.2009-02:47 

Thank you!

But bugs remain ;)

The code compiles nicely now, but finally i found the source of my _extended_ misery:
You are calling Sound_Init() regardless of if bEnableSound is TRUE or FALSE.

This is the correct behaviour, in case people are reading YM-registers, blinking the floppy lamp or using other stuff that is mapped to the YM registers (Falcon). It does however, depend on values that requires sound to be enabled. This is very bad.

It had me crashing and burning for hours now, didnt occur to me the config was not properly dealt with... A set of unit tests would not hurt ;)

On another note, when changing names of stuff in hatari.cfg, you will want to keep the old names, and throw a warning or so, at least for a couple of versions...

The solution is to run Audio_SetOuputAudioFreq() regardless of if the sound is enabled, remove the if(bSoundWorking) inside that call, remove the rogue returns from Audio_Init() and pay close attention to any side effects from the fact that everything seems to be checked and double checked all the time (a convention would be nice... or even better; a couple of runlevels for audio would work. the bSoundWorking idiom is not doing the job, sorry).

So, if all this is a bit overwhealming, i suppose i could contribute a patch...

Oh my, i should be asleep by now! And there is all this backpatching to work out... If you guys want the OSX binary tomorrow, ask nicely and i will make whatever version i have at the moment available :)

/Kaare







[All messages in this thread]    [Start new thread]

Topic Posted by  Date 
hatari once again! mikro Apr,24.2009-18:51
  Re: hatari once again! trophy Apr,24.2009-21:17
  Re: hatari once again! evil Apr,25.2009-17:20
    Re: hatari once again! Simon Sunnyboy / Paradize Apr,25.2009-18:29
      Re: hatari once again! evil Apr,25.2009-18:52
        Performance problems thothy Apr,28.2009-23:10
          Re: Performance problems evil Apr,29.2009-16:12
            Re: Performance problems nerve Apr,29.2009-18:53
              Re: Performance problems Patrice Mandin Apr,30.2009-11:25
                Re: Performance problems nerve Apr,30.2009-16:00
              Re: Performance problems thothy Apr,30.2009-20:54
                Re: Performance problems nerve Apr,30.2009-23:07
                  Re: Performance problems thothy May,01.2009-00:01
                    Re: Performance problems nerve May,01.2009-02:47
                      Re: Performance problems thothy May,01.2009-13:21
                        Re: Performance problems nerve May,01.2009-16:41
                          Re: Performance problems thothy May,01.2009-20:00
                            Re: Performance problems nerve May,01.2009-20:22
                              Re: Performance problems thothy May,02.2009-00:13
    Re: hatari once again! mikro Apr,25.2009-18:29
  Re: hatari once again! evil Apr,25.2009-18:53
    Re: hatari once again! Dma-Sc Apr,26.2009-09:43
      Re: hatari once again! CiH Apr,26.2009-19:02
        Re: hatari once again! mikro Apr,26.2009-20:11
          Re: hatari once again! Laurent Sallafranque Apr,27.2009-10:03
            Re: hatari once again! Mic/Dune Apr,27.2009-11:15
              Re: hatari once again! Laurent Sallafranque Apr,27.2009-14:08
          Re: hatari once again! Patrice Mandin Apr,27.2009-14:00
        Re: hatari once again! thothy Apr,28.2009-23:19
          Re: hatari once again! marakatti Apr,29.2009-06:41
            Re: hatari once again! nerve Apr,29.2009-09:36
          Re: hatari once again! Chuck Apr,30.2009-23:30


Reply to this message
Name:
Topic:
Anti-troll code:

Message:

What's the anti-troll code?
That's your personal code to be able to add comments and messages on the dhs.nu site.
Don't have a code or forgot it? Fix it here.
© 1994-2025 Dead Hackers Society Contact: Anders Eriksson